Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFM内でURLを<>で囲った際に、URLプレビューが表示されないように #13863

Conversation

anatawa12
Copy link
Member

What

Fix #12902

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@anatawa12 anatawa12 added the ☢️Breaking This change breaks compatibility label May 22, 2024
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label May 22, 2024
@anatawa12 anatawa12 changed the title MFM内でURLを<>で囲った際に、URLプレビューが表示されないようになりました MFM内でURLを<>で囲った際に、URLプレビューが表示されないように May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.65%. Comparing base (f8261a1) to head (1d405d7).
Report is 575 commits behind head on develop.

Files Patch % Lines
...kages/frontend/src/scripts/extract-url-from-mfm.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13863      +/-   ##
===========================================
- Coverage    79.95%   77.65%   -2.31%     
===========================================
  Files          956      183     -773     
  Lines       108864    25384   -83480     
  Branches      8413      487    -7926     
===========================================
- Hits         87045    19712   -67333     
+ Misses       21819     5665   -16154     
- Partials         0        7       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented May 22, 2024

URLプレビュー表示されてほしい

@anatawa12
Copy link
Member Author

anatawa12 commented May 22, 2024

?[text](link)のような感じで?<>的な構文はやすほうがいいですかね

@syuilo
Copy link
Member

syuilo commented May 22, 2024

そうね

@anatawa12
Copy link
Member Author

では一旦closeします

@anatawa12 anatawa12 closed this May 22, 2024
@anatawa12 anatawa12 deleted the no-url-preview-if-url-is-in-brackets branch May 24, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☢️Breaking This change breaks compatibility packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MFM] リンク構文でないURLのリンクプレビューを無効化する構文が欲しい
2 participants