Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unsuspended remote user cannot interact to local #13890

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Hoto-Cocoa
Copy link
Contributor

@Hoto-Cocoa Hoto-Cocoa commented May 27, 2024

What

Fixes #13504.

Why

See #13504.

Additional info (optional)

Currently it is WIP. Now ready to merge.

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@Hoto-Cocoa Hoto-Cocoa marked this pull request as draft May 27, 2024 11:41
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label May 27, 2024
@Hoto-Cocoa Hoto-Cocoa force-pushed the fix/remote-user-unsuspend-federation branch from 3365378 to d554155 Compare May 27, 2024 11:41
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 64.95%. Comparing base (2b8056a) to head (2a01e67).

Files Patch % Lines
...ackend/src/core/activitypub/ApDbResolverService.ts 28.57% 15 Missing ⚠️
.../queue/processors/DeleteAccountProcessorService.ts 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13890      +/-   ##
===========================================
- Coverage    64.95%   64.95%   -0.01%     
===========================================
  Files          989      989              
  Lines       112848   112873      +25     
  Branches      5770     5822      +52     
===========================================
+ Hits         73306    73320      +14     
- Misses       38100    38111      +11     
  Partials      1442     1442              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 27, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@Hoto-Cocoa Hoto-Cocoa force-pushed the fix/remote-user-unsuspend-federation branch from d554155 to 8589b24 Compare May 27, 2024 12:40
@Hoto-Cocoa Hoto-Cocoa marked this pull request as ready for review May 27, 2024 13:14
@Hoto-Cocoa
Copy link
Contributor Author

I did test and everything works as I expected and desired.

@Hoto-Cocoa Hoto-Cocoa force-pushed the fix/remote-user-unsuspend-federation branch 3 times, most recently from 868c52b to 0365c45 Compare May 30, 2024 08:33
@Hoto-Cocoa Hoto-Cocoa force-pushed the fix/remote-user-unsuspend-federation branch from 0365c45 to 2a01e67 Compare June 1, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

リモートユーザーの一時停止を解除した後は user.isDeleted = true
1 participant