Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): explicitly set query runner on insertOne #13922

Closed
wants to merge 4 commits into from

Conversation

acid-chicken
Copy link
Member

What

insertOne 問い合わせ時 TypeORM が選択している QueryRunner が不適切な可能性があるので明示的に指定する

Why

May fix #13921

Additional info (optional)

wip

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jun 1, 2024
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 81.57895% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 64.89%. Comparing base (2b8056a) to head (d021984).

Files Patch % Lines
packages/backend/src/models/_.ts 81.57% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13922      +/-   ##
===========================================
- Coverage    64.95%   64.89%   -0.07%     
===========================================
  Files          989      987       -2     
  Lines       112848   112687     -161     
  Branches      5770     5815      +45     
===========================================
- Hits         73306    73131     -175     
- Misses       38100    38114      +14     
  Partials      1442     1442              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 1, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@acid-chicken acid-chicken marked this pull request as ready for review June 1, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
1 participant