Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): update ApPersonService to handle user without endpoint #14080

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

PichuChen
Copy link

What

Fix #13735

Why

endpoint または sharedInbox がnullの場合、更新をスキップします

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jun 23, 2024
Copy link
Contributor

github-actions bot commented Jun 23, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 40.16%. Comparing base (efb0429) to head (2f55c80).
Report is 14 commits behind head on develop.

Files Patch % Lines
...end/src/core/activitypub/models/ApPersonService.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14080      +/-   ##
===========================================
- Coverage    42.07%   40.16%   -1.91%     
===========================================
  Files         1527     1523       -4     
  Lines       195068   189025    -6043     
  Branches      2688     2668      -20     
===========================================
- Hits         82079    75931    -6148     
- Misses      112448   112553     +105     
  Partials       541      541              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PichuChen PichuChen changed the title chore(backend): update ApPersonService to handle user without endpoint fix(backend): update ApPersonService to handle user without endpoint Jun 23, 2024
@tamaina
Copy link
Contributor

tamaina commented Jul 17, 2024

「sharedInboxがなくなった」という内容のアップデートがあった場合にnullに更新できなくなりそう

@PichuChen
Copy link
Author

「sharedInboxがなくなった」という内容のアップデートがあった場合にnullに更新できなくなりそう

はい、ただし、どのような状況でsharedInboxがもともと存在していた状況がsharedInboxが存在しない状況、つまりnullの状況になるのかはわかりません。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

sharedInboxが無いActorに紐づくリモートユーザーを照会できない
2 participants