Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): emojiPickerを使用して絵文字を挿入する際、refに直接挿入するように #14282

Merged
merged 2 commits into from
Jul 30, 2024
+14 −1
Merged

fix(frontend): emojiPickerを使用して絵文字を挿入する際、refに直接挿入するように #14282

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20e906e
fix(frontend): emojiPickerを使用して絵文字を挿入する際、refに直接挿入するように
kakkokari-gtyih Jul 21, 2024
86e2529
add comment
kakkokari-gtyih Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/frontend/src/components/MkPostForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,10 +902,23 @@ async function insertEmoji(ev: MouseEvent) {
textAreaReadOnly.value = true;
const target = ev.currentTarget ?? ev.target;
if (target == null) return;

// emojiPickerはダイアログが閉じずにtextareaとやりとりするので、
// focustrapをかけているとinsertTextAtCursorが効かない
// そのため、投稿フォームのテキストに直接注入する
// See: https://github.com/misskey-dev/misskey/pull/14282
// https://github.com/misskey-dev/misskey/issues/14274

let pos = textareaEl.value?.selectionStart ?? 0;
let posEnd = textareaEl.value?.selectionEnd ?? text.value.length;
emojiPicker.show(
target as HTMLElement,
emoji => {
insertTextAtCursor(textareaEl.value, emoji);
const textBefore = text.value.substring(0, pos);
const textAfter = text.value.substring(posEnd);
text.value = textBefore + emoji + textAfter;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これiOS環境で動きます？
safariだとtextareaの値を操作するのにフォーカスが必要で…みたいなのをどこかで見た記憶があり

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ios端末を持ってないので検証できない・・・

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ネットを軽く検索した所そういった文献は見つからなかったけど検証できないのでなんとも

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS持ちのかたにtgaでプレビューして確かめて貰う必要がありそう

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

フォーカス当たってなくてもvalueの変更が効く可能性がある（まだn=1なのでもう少し検証がほしいところ）

https://misskey.systems/channels/9le8h3kb0q

image

pos += emoji.length;
posEnd += emoji.length;
},
() => {
textAreaReadOnly.value = false;
Expand Down
Loading