enhance(backend): headタグ内にrel=alternateの指定のあるlinkタグがある場合、記述されたURLを参照して照会できるように #14371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
このPRによるapi.jsonの差分 差分はこちら |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14371 +/- ##
===========================================
- Coverage 41.61% 39.87% -1.74%
===========================================
Files 1551 1547 -4
Lines 196905 190875 -6030
Branches 2772 3552 +780
===========================================
- Hits 81941 76116 -5825
+ Misses 114400 114167 -233
- Partials 564 592 +28 ☔ View full report in Codecov by Sentry. |
tai-cha
force-pushed
the
feat/ap_show_alternate
branch
from
c5c5602 to
b15133c
Compare
|
テスト追加できたりするかしら |
|
APのSignedGetだからどうテスト書けばいいか悩んでいる (方針さえわかればかける)(というかそれがわからずテストを書いていないまであります) ダミーのサイトもう一つ用意するようなテストになる？ |
|
なんかモックできたような気がする |
|
👍🏻 |
LemonDouble
pushed a commit
to LemonDouble/misskey
that referenced
this pull request
Aug 19, 2024
…て照会できるように (misskey-dev#14371) * signedGet時にhttpかつalternate属性のlinkがある場合に一回だけfollowして照会する * Fix: validation position * Fix import * Fix tagname * Update CHANGELOG * Fix code style --------- Co-authored-by: syuilo <[email protected]>
u1-liquid
pushed a commit
to MisskeyIO/misskey
that referenced
this pull request
Dec 24, 2024
…て照会できるように (misskey-dev#14371) cherry picked from commit 9fbc1b7 Co-authored-by: syuilo <[email protected]> Co-authored-by: taichan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
ThreadsのようなHTMLのheadタグ内に
<link rel="alternate" href="https://example.com/activity/json/path/" type="application/activity+json">のようなタグがある場合にそちらを追って照会できるようにWhy
resolve: #14348
Additional info (optional)
DOMを見るのでパフォーマンス上の懸念はある
リファクタの余地もあるかも（とりあえず動作確認はできた）
Checklist