-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: readAllNotifications message not working #14374
Conversation
このPRによるapi.jsonの差分 差分はこちら |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14374 +/- ##
============================================
- Coverage 66.21% 39.92% -26.30%
============================================
Files 990 1544 +554
Lines 117137 190368 +73231
Branches 4489 2692 -1797
============================================
- Hits 77568 75995 -1573
- Misses 39538 113813 +74275
- Partials 31 560 +529 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sayamame-beans <[email protected]>
🙏 |
|
🙏🏻 |
* refactor: add and use isJsonObject * fix: readNotification message without body is not working * docs(changelog): WSの`readAllNotifications` メッセージが `body` を持たない場合に動作しない問題 * Update CHANGELOG.md Co-authored-by: Sayamame-beans <[email protected]> --------- Co-authored-by: Sayamame-beans <[email protected]>
What
Fix #14367
readAllNotificationsメッセージにペイロードがないときに動かなくなっていたのを修正します
Why
Additional info (optional)
Checklist