Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: localizable dialog title for enter section title #14401

Conversation

anatawa12
Copy link
Member

What

Fix #5665

ついでに小さなrefactorを入れました

変更量の小ささからCHANGELOGはなしでいいと判断してます。

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 13, 2024
@anatawa12 anatawa12 force-pushed the localizable-title-for-enter-page-section-title branch from 5d48958 to bfcaf76 Compare August 13, 2024 12:18
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 20.24%. Comparing base (41936c1) to head (bfcaf76).
Report is 8 commits behind head on develop.

Files Patch % Lines
packages/frontend/src/pages/page-editor/common.ts 0.00% 14 Missing and 1 partial ⚠️
...c/pages/page-editor/els/page-editor.el.section.vue 0.00% 2 Missing ⚠️
...ges/frontend/src/pages/page-editor/page-editor.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14401       +/-   ##
============================================
- Coverage    39.91%   20.24%   -19.67%     
============================================
  Files         1545      724      -821     
  Lines       190505   100288    -90217     
  Branches      2654     1050     -1604     
============================================
- Hits         76046    20308    -55738     
+ Misses      113898    79438    -34460     
+ Partials       561      542       -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih modified the milestone: v2024.8.0 Aug 13, 2024
@syuilo syuilo merged commit 748a7e8 into misskey-dev:develop Aug 16, 2024
18 of 19 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 16, 2024

🙏🏿

@anatawa12 anatawa12 deleted the localizable-title-for-enter-page-section-title branch August 16, 2024 12:47
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
…4401)

* feat: localizable dialog title for enter section title

* refactor: define `getPageBlockList` in separated file and import instead of provide/inject
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title of the 'Enter title' dialog is not localized.
3 participants