Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Misskeyの利用中に使用できるタイムラインの種類が変化した場合、使用できないタイムラインが表示されないように #14412

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Aug 15, 2024

What

ポリシーの変更などで使用できるタイムラインが変化しても、初回読み込みやページ遷移からの回復などで使用できなくなったタイムラインのページが表示できてしまうのを修正

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 20.18%. Comparing base (41936c1) to head (505b0ea).
Report is 7 commits behind head on develop.

Files Patch % Lines
packages/frontend/src/pages/timeline.vue 0.00% 20 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14412       +/-   ##
============================================
- Coverage    39.91%   20.18%   -19.74%     
============================================
  Files         1545      723      -822     
  Lines       190505   100300    -90205     
  Branches      2654     1050     -1604     
============================================
- Hits         76046    20244    -55802     
+ Misses      113898    79514    -34384     
+ Partials       561      542       -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 6db3c50 into misskey-dev:develop Aug 16, 2024
17 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 16, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-tlsrc-policychanges branch August 16, 2024 13:01
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
…うに (misskey-dev#14412)

* fix(frontend): Misskeyの利用中に使用できるタイムラインの種類が変化した場合、使用できないタイムラインが表示されないように

* Update timeline.vue

* Update timeline.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants