-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): use prefixItems
in admin/queue/*-delayed
endpoint schema
#14468
fix(backend): use prefixItems
in admin/queue/*-delayed
endpoint schema
#14468
Conversation
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -9912,16 +9912,15 @@
"type": "array",
"items": {
"type": "array",
- "items": {
- "anyOf": [
- {
- "type": "string"
- },
- {
- "type": "number"
- }
- ]
- }
+ "prefixItems": [
+ {
+ "type": "string"
+ },
+ {
+ "type": "number"
+ }
+ ],
+ "unevaluatedItems": false
},
"example": [
[
@@ -10067,16 +10066,15 @@
"type": "array",
"items": {
"type": "array",
- "items": {
- "anyOf": [
- {
- "type": "string"
- },
- {
- "type": "number"
- }
- ]
- }
+ "prefixItems": [
+ {
+ "type": "string"
+ },
+ {
+ "type": "number"
+ }
+ ],
+ "unevaluatedItems": false
},
"example": [
[ |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14468 +/- ##
============================================
+ Coverage 20.21% 41.69% +21.47%
============================================
Files 725 1551 +826
Lines 100550 197057 +96507
Branches 1050 3568 +2518
============================================
+ Hits 20327 82159 +61832
- Misses 79681 114306 +34625
- Partials 542 592 +50 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM. ありがとうございます 🙏🏻
packages/backend/src/server/api/endpoints/admin/queue/deliver-delayed.ts
Show resolved
Hide resolved
🙏🏿 |
What
admin/queue/*-delayed
エンドポイントのレスポンススキーマにおいて、タプルの表現にitems
,anyOf
が使われていたのをprefixItems
を使うように修正し、関連するフロントエンドでの型エラーを解消します。Why
Additional info (optional)
Checklist