-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix Invalid regular expression on iOS <= 16.3 #14560
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14560 +/- ##
============================================
+ Coverage 19.72% 41.36% +21.63%
============================================
Files 714 1540 +826
Lines 100375 196621 +96246
Branches 996 3568 +2572
============================================
+ Hits 19802 81324 +61522
- Misses 80030 114704 +34674
- Partials 543 593 +50 ☔ View full report in Codecov by Sentry. |
@misskey-dev/dev iOS <= 16.3ってサポート対象だっけ |
前回見た時は16.3以上が動く感じだったようですが…今はどうでしょうか |
私はiOS 16.x latestが対象と認識してるので対応しなくていいと認識してた (browserlistとかを明示的に書いてちゃんとメンテしたほうがいいかも) |
これやるとメンテナンス性終わって悲しくなるので16.3以下は切って良さそう |
iOS <= 16.3 はサポート範囲外だったのでcloseします 🙏🏻 |
What
Use
replaceAll
instead of RegExp lookbehind assertion.Why
RegExp Lookbehind Assertions are not supported on iOS 16.3 and below, the web app failed to load (ERROR CODE: APP_IMPORT), and throws an exception:
Similar problem: #10328 (comment)
Additional info (optional)
Checklist