Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Invalid regular expression on iOS <= 16.3 #14560

Closed
wants to merge 5 commits into from

Conversation

Ljzd-PRO
Copy link

What

Use replaceAll instead of RegExp lookbehind assertion.

Why

RegExp Lookbehind Assertions are not supported on iOS 16.3 and below, the web app failed to load (ERROR CODE: APP_IMPORT), and throws an exception:

SyntaxError: Invalid regular expression: invalid group specifier name

Similar problem: #10328 (comment)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.36%. Comparing base (3bf63dd) to head (aa38c7f).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14560       +/-   ##
============================================
+ Coverage    19.72%   41.36%   +21.63%     
============================================
  Files          714     1540      +826     
  Lines       100375   196621    +96246     
  Branches       996     3568     +2572     
============================================
+ Hits         19802    81324    +61522     
- Misses       80030   114704    +34674     
- Partials       543      593       +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Sep 16, 2024

@misskey-dev/dev iOS <= 16.3ってサポート対象だっけ

@Sayamame-beans
Copy link
Member

前回見た時は16.3以上が動く感じだったようですが…今はどうでしょうか
#12875 (comment)

@anatawa12
Copy link
Member

私はiOS 16.x latestが対象と認識してるので対応しなくていいと認識してた

(browserlistとかを明示的に書いてちゃんとメンテしたほうがいいかも)

@KisaragiEffective
Copy link
Collaborator

これやるとメンテナンス性終わって悲しくなるので16.3以下は切って良さそう

CHANGELOG.md Outdated Show resolved Hide resolved
@syuilo
Copy link
Member

syuilo commented Sep 18, 2024

iOS <= 16.3 はサポート範囲外だったのでcloseします 🙏🏻

@syuilo syuilo closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants