Misskey® Reactions Buffering Technology™

[syuilo]

What

Resolve #11093

Why

See #11093

Additional info (optional)

• reactionAndUserPairCacheの扱い

Checklist

• Read the contribution guide
• Test working in a local environment
• (If needed) Add story of storybook
• (If needed) Update CHANGELOG.md
• (If possible) Add tests

[github-actions]

このPRによるapi.jsonの差分

差分はこちら

--- base
+++ head
@@ -416,6 +416,9 @@
                     "perUserListTimelineCacheMax": {
                       "type": "number"
                     },
+                    "enableReactionsBuffering": {
+                      "type": "boolean"
+                    },
                     "notesPerOneAd": {
                       "type": "number"
                     },
@@ -636,6 +639,7 @@
                     "perRemoteUserUserTimelineCacheMax",
                     "perUserHomeTimelineCacheMax",
                     "perUserListTimelineCacheMax",
+                    "enableReactionsBuffering",
                     "notesPerOneAd",
                     "backgroundImageUrl",
                     "deeplAuthKey",
@@ -13860,6 +13864,9 @@
                   "perUserListTimelineCacheMax": {
                     "type": "integer"
                   },
+                  "enableReactionsBuffering": {
+                    "type": "boolean"
+                  },
                   "notesPerOneAd": {
                     "type": "integer"
                   },

Get diff files from Workflow Page

[codecov]

Codecov Report

Attention: Patch coverage is 29.83683% with 301 lines in your changes missing coverage. Please review.

Project coverage is 41.39%. Comparing base (4ac8aad) to head (0127b9f).
Report is 5 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ages/backend/src/core/ReactionsBufferingService.ts	25.92%	120 Missing ⚠️
...ckages/frontend/src/pages/admin/other-settings.vue	0.00%	72 Missing ⚠️
...ges/backend/src/core/entities/NoteEntityService.ts	16.92%	54 Missing ⚠️
packages/backend/src/core/ReactionService.ts	8.33%	33 Missing ⚠️
...rocessors/BakeBufferedReactionsProcessorService.ts	67.50%	13 Missing ⚠️
packages/backend/src/server/HealthServerService.ts	0.00%	4 Missing ⚠️
...kend/src/server/api/endpoints/admin/update-meta.ts	20.00%	4 Missing ⚠️
...ges/backend/src/server/api/endpoints/admin/meta.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #14579      +/-   ##
===========================================
- Coverage    41.43%   41.39%   -0.05%     
===========================================
  Files         1543     1545       +2     
  Lines       197423   197761     +338     
  Branches      3603     3561      -42     
===========================================
+ Hits         81809    81867      +58     
- Misses      115020   115330     +310     
+ Partials       594      564      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[syuilo]

マージするか

[tai-cha]

動作は見れてないけどコードを目で追った感じはYOSASOU

[syuilo]

🙏🏿

[syuilo]

（RBTがオフの状態でも）リアクション分裂現象が起こっている

[syuilo]

TASUKETE

[fruitriin]

(自分がポストしたとき？)ホスト名がnullではなく.になっていて、一致しなくて分裂しているらしい？

[kakkokari-gtyih]

旧バージョン

RBT導入後

なのでローカルの絵文字のホスト名のハンドリングをどちらかに寄せる必要がありそう

[kakkokari-gtyih]

これでいけたりする？（L71, 72）