-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): Retry-After
ヘッダーが実際には送信されなかった問題を修正
#14597
fix(backend): Retry-After
ヘッダーが実際には送信されなかった問題を修正
#14597
Conversation
a rate-limit-exceeded error has `kind:'client'`, so the branch that adds the `Retry-After` would never get taken (cherry picked from commit 8a982c6)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14597 +/- ##
===========================================
- Coverage 41.47% 39.70% -1.77%
===========================================
Files 1545 1541 -4
Lines 197945 192208 -5737
Branches 3568 2562 -1006
===========================================
- Hits 82104 76324 -5780
- Misses 115247 115320 +73
+ Partials 594 564 -30 ☔ View full report in Codecov by Sentry. |
このPRによるapi.jsonの差分 差分はこちら |
これっぽいかも(retry-afterを送信する条件の前にkind:clientの条件に入ってヘッダが送信されない) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
落ち着いて見たらそれで確定してそう
自明なのでマージして良い? |
Retry-After
ヘッダーが実際には送信されかった問題を修正Retry-After
ヘッダーが実際には送信されなかった問題を修正
🙏🏿 |
What
かいてあるとおり
Why
https://activitypub.software/TransFem-org/Sharkey/-/commit/8a982c61c01909e7540ff1be9f019df07c3f0624
Additional info (optional)
原因調査後 KisaragiEffective さんに確認していただくためDraftdoneChecklist