Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Retry-Afterヘッダーが実際には送信されなかった問題を修正 #14597

Merged
merged 4 commits into from
Sep 21, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Sep 21, 2024

What

かいてあるとおり

Why

https://activitypub.software/TransFem-org/Sharkey/-/commit/8a982c61c01909e7540ff1be9f019df07c3f0624

Additional info (optional)

原因調査後 KisaragiEffective さんに確認していただくためDraft done

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

dakkar and others added 2 commits September 21, 2024 11:37
a rate-limit-exceeded error has `kind:'client'`, so the branch that
adds the `Retry-After` would never get taken

(cherry picked from commit 8a982c6)
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Sep 21, 2024
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 39.70%. Comparing base (a18a6ac) to head (991b486).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/server/api/ApiCallService.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14597      +/-   ##
===========================================
- Coverage    41.47%   39.70%   -1.77%     
===========================================
  Files         1545     1541       -4     
  Lines       197945   192208    -5737     
  Branches      3568     2562    -1006     
===========================================
- Hits         82104    76324    -5780     
- Misses      115247   115320      +73     
+ Partials       594      564      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 21, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Sep 21, 2024

a rate-limit-exceeded error has kind:'client', so the branch that adds the Retry-After would never get taken

これっぽいかも(retry-afterを送信する条件の前にkind:clientの条件に入ってヘッダが送信されない)

Copy link
Collaborator

@KisaragiEffective KisaragiEffective left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

落ち着いて見たらそれで確定してそう

@KisaragiEffective KisaragiEffective marked this pull request as ready for review September 21, 2024 02:51
@KisaragiEffective
Copy link
Collaborator

自明なのでマージして良い?

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.9.0 milestone Sep 21, 2024
@kakkokari-gtyih kakkokari-gtyih changed the title fix(backend): Retry-Afterヘッダーが実際には送信されかった問題を修正 fix(backend): Retry-Afterヘッダーが実際には送信されなかった問題を修正 Sep 21, 2024
@syuilo syuilo merged commit 85f46f8 into misskey-dev:develop Sep 21, 2024
29 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 21, 2024

🙏🏿

@kakkokari-gtyih kakkokari-gtyih deleted the fix-retry-after-never-set branch September 21, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants