Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EmailServiceでインラインスタイルを適用するように #14600

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

1673beta
Copy link
Contributor

What

EmailService中のHTMLにインラインCSSを適用するように

before
image
after
image

Why

close #8888

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Sep 21, 2024
Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 39.64%. Comparing base (a18a6ac) to head (1cd0cdb).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/EmailService.ts 7.14% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14600      +/-   ##
===========================================
- Coverage    41.47%   39.64%   -1.83%     
===========================================
  Files         1545     1541       -4     
  Lines       197945   192213    -5732     
  Branches      3568     2491    -1077     
===========================================
- Hits         82104    76212    -5892     
- Misses      115247   115437     +190     
+ Partials       594      564      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit d4d15f3 into misskey-dev:develop Sep 21, 2024
30 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 21, 2024

🙏🏿🙏🏿🙏🏿

@kakkokari-gtyih
Copy link
Contributor

Changelogがいりそう(後でやっておく)

@1673beta
Copy link
Contributor Author

お願いします🙇(忘れてた)

kakkokari-gtyih added a commit to kakkokari-gtyih/misskey that referenced this pull request Sep 25, 2024
kakkokari-gtyih added a commit that referenced this pull request Sep 25, 2024
* fix(docs): RBTの表記ゆれを訂正

* add changelog for #14600

* fix
HotoRas pushed a commit to HotoRas/misskey-neko that referenced this pull request Sep 27, 2024
* fix(docs): RBTの表記ゆれを訂正

* add changelog for misskey-dev#14600

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTMLメールが崩れる
3 participants