Fix: <link rel="alternate">を追って照会するのはOKレスポンスが返却された場合のみに
#14627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
このPRによるapi.jsonの差分 |
|
メモ: sourceはシンプルに「ダウンしてる時に追うのはよくない」と言っている |
KisaragiEffective
approved these changes
Sep 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14627 +/- ##
===========================================
- Coverage 39.67% 39.57% -0.10%
===========================================
Files 1542 1542
Lines 192781 192785 +4
Branches 2475 3540 +1065
===========================================
- Hits 76492 76302 -190
- Misses 115726 115886 +160
- Partials 563 597 +34 ☔ View full report in Codecov by Sentry. |
|
🙏🏻 |
kakkokari-gtyih
deleted the
fix-only-accept-html-alternate-on-success
branch
HotoRas
pushed a commit
to HotoRas/misskey-neko
that referenced
this pull request
Sep 27, 2024
…v#14627) * Only accept HTML `<link rel="alternate">` on success (cherry picked from commit 6ea48be) * Use `res.ok` instead of 200-299 (cherry picked from commit b667a68) * jsdomに戻す * Update Changelog * Revert "jsdomに戻す" This reverts commit c036036. * 🎨 --------- Co-authored-by: Julia Johannesen <[email protected]>
u1-liquid
added a commit
to MisskeyIO/misskey
that referenced
this pull request
Dec 24, 2024
…v#14627) cherry picked from commit dd124a8 Co-authored-by: Julia Johannesen <[email protected]> Co-authored-by: かっこかり <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Additional info (optional)
Checklist