Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(backend): Add test for Passkey API #14635

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

yunochi
Copy link
Contributor

@yunochi yunochi commented Sep 26, 2024

What

Add some test for Passkey Sign In API.

Why

#14577 (comment)

Additional info (optional)

I still don't know how to simulate webauthn tokens, so I couldn't create full E2E test.
The part that verifies the token has been replaced with a mock.

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/backend:test labels Sep 26, 2024
@yunochi yunochi marked this pull request as ready for review September 26, 2024 04:24
Copy link
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.65%. Comparing base (89841e4) to head (a9e857b).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14635      +/-   ##
===========================================
+ Coverage    39.57%   39.65%   +0.08%     
===========================================
  Files         1544     1544              
  Lines       193244   193244              
  Branches      3563     2560    -1003     
===========================================
+ Hits         76470    76631     +161     
+ Misses      116209   116048     -161     
  Partials       565      565              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih added this to the v2024.9.0 milestone Sep 26, 2024
@syuilo syuilo merged commit b83a2f3 into misskey-dev:develop Sep 27, 2024
33 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 27, 2024

🙏🏿

@yunochi yunochi deleted the sign-in-with-passkey-test branch October 30, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants