Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): Split the name and username onto separate lines. #14668

Closed

Conversation

Natsuki-Kaede
Copy link

What

Split the name and username onto separate lines.

Why

close #14667

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 2, 2024
@Natsuki-Kaede Natsuki-Kaede changed the title Split the name and username onto separate lines. enhance(frontend): Split the name and username onto separate lines. Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.

Project coverage is 19.54%. Comparing base (e9519b0) to head (96d4663).

Files with missing lines Patch % Lines
...ackages/frontend/src/components/MkNoteDetailed.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14668       +/-   ##
============================================
- Coverage    41.40%   19.54%   -21.87%     
============================================
  Files         1549      716      -833     
  Lines       199468   101516    -97952     
  Branches      3623      987     -2636     
============================================
- Hits         82595    19840    -62755     
+ Misses      116276    81130    -35146     
+ Partials       597      546       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natsuki-Kaede
Copy link
Author

Ummm sorry I'll create another cleaner one

@Natsuki-Kaede Natsuki-Kaede deleted the feat/tweak-note-header branch October 3, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Split the name and username onto separate lines.
1 participant