Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): deleted remote users could be shown in users/show endpoint #14752

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zyoshoka
Copy link
Contributor

What

users/show エンドポイントに削除したリモートユーザーを指定しても取得できてしまう問題を修正

Why

Closes #14728

Additional info (optional)

他のエンドポイントでも塞ぐべきでしょうがそもそも isSuspended についてもそうなっていない、というケースが多いようなのでひとまず users/show エンドポイントのみの対応としています

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Oct 11, 2024
Copy link
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.54%. Comparing base (12bc671) to head (08a6260).

Files with missing lines Patch % Lines
...ges/backend/src/server/api/endpoints/users/show.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14752      +/-   ##
===========================================
- Coverage    39.66%   38.54%   -1.13%     
===========================================
  Files         1553     1553              
  Lines       195050   195051       +1     
  Branches      2574     3320     +746     
===========================================
- Hits         77363    75175    -2188     
- Misses      117119   119269    +2150     
- Partials       568      607      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

リモートユーザーが削除できない
1 participant