Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: クライアント設定の初期値を変更できるように(簡易) #14883

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Nov 2, 2024

What

defaultStore/coldDeviceStorageの生の値を変更できるように
(設定ごとのUIを用意しようと思うとものすごく大変なのでいったんこれで)

image

Why

Fix #12952
Fix #14436

Additional info (optional)

初期値変更によって動作がおかしくなった場所があるので確認中

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Nov 2, 2024
Copy link
Contributor

github-actions bot commented Nov 2, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -461,6 +461,12 @@
                         "null"
                       ]
                     },
+                    "defaultClientSettingOverrides": {
+                      "type": [
+                        "string",
+                        "null"
+                      ]
+                    },
                     "description": {
                       "type": [
                         "string",
@@ -670,6 +676,7 @@
                     "deeplIsPro",
                     "defaultDarkTheme",
                     "defaultLightTheme",
+                    "defaultClientSettingOverrides",
                     "description",
                     "disableRegistration",
                     "impressumUrl",
@@ -13959,6 +13966,12 @@
                       "null"
                     ]
                   },
+                  "defaultClientSettingOverrides": {
+                    "type": [
+                      "string",
+                      "null"
+                    ]
+                  },
                   "cacheRemoteFiles": {
                     "type": "boolean"
                   },
@@ -82362,6 +82375,12 @@
               "serviceWorker"
             ]
           },
+          "defaultClientSettingOverrides": {
+            "type": [
+              "string",
+              "null"
+            ]
+          },
           "proxyAccountName": {
             "type": [
               "string",
@@ -82380,6 +82399,7 @@
           }
         },
         "required": [
+          "defaultClientSettingOverrides",
           "proxyAccountName",
           "requireSetup",
           "cacheRemoteFiles",

Get diff files from Workflow Page

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 5.25000% with 379 lines in your changes missing coverage. Please review.

Project coverage is 41.02%. Comparing base (224bbd4) to head (b6ca1a5).

Files with missing lines Patch % Lines
...ntend/src/pages/admin/client-setting-overrides.vue 0.00% 270 Missing and 1 partial ⚠️
packages/frontend/src/scripts/store-overrides.ts 0.00% 32 Missing and 1 partial ⚠️
packages/frontend/src/pizzax.ts 0.00% 30 Missing ⚠️
packages/frontend/src/instance.ts 30.00% 14 Missing ⚠️
packages/frontend/src/boot/common.ts 0.00% 9 Missing ⚠️
...kend/src/server/api/endpoints/admin/update-meta.ts 20.00% 4 Missing ⚠️
packages/frontend/src/router/definition.ts 0.00% 4 Missing ⚠️
packages/frontend/src/scripts/merge.ts 0.00% 4 Missing ⚠️
packages/frontend/src/store.ts 0.00% 4 Missing ⚠️
packages/frontend/src/pages/admin/settings.vue 0.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14883      +/-   ##
===========================================
+ Coverage    39.47%   41.02%   +1.54%     
===========================================
  Files         1559     1565       +6     
  Lines       196944   203076    +6132     
  Branches      3616     3598      -18     
===========================================
+ Hits         77747    83308    +5561     
- Misses      118591   119158     +567     
- Partials       606      610       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo requested review from samunohito and removed request for samunohito November 2, 2024 23:24
@syuilo
Copy link
Member

syuilo commented Nov 2, 2024

今まで内部的に持っていたデータがパブリックなものになると気軽に改修できなくなるから大変そう

@syuilo
Copy link
Member

syuilo commented Nov 2, 2024

するなら抽象化レイヤーを挟んだ方が良さそう(既にそうなってるのかもしれないけど)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
2 participants