-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: クライアント設定の初期値を変更できるように(簡易) #14883
Draft
kakkokari-gtyih
wants to merge
4
commits into
misskey-dev:develop
Choose a base branch
from
kakkokari-gtyih:enh-12952
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+450
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/frontend
Client side specific issue/PR
packages/backend
Server side specific issue/PR
packages/misskey-js
labels
Nov 2, 2024
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -461,6 +461,12 @@
"null"
]
},
+ "defaultClientSettingOverrides": {
+ "type": [
+ "string",
+ "null"
+ ]
+ },
"description": {
"type": [
"string",
@@ -670,6 +676,7 @@
"deeplIsPro",
"defaultDarkTheme",
"defaultLightTheme",
+ "defaultClientSettingOverrides",
"description",
"disableRegistration",
"impressumUrl",
@@ -13959,6 +13966,12 @@
"null"
]
},
+ "defaultClientSettingOverrides": {
+ "type": [
+ "string",
+ "null"
+ ]
+ },
"cacheRemoteFiles": {
"type": "boolean"
},
@@ -82362,6 +82375,12 @@
"serviceWorker"
]
},
+ "defaultClientSettingOverrides": {
+ "type": [
+ "string",
+ "null"
+ ]
+ },
"proxyAccountName": {
"type": [
"string",
@@ -82380,6 +82399,7 @@
}
},
"required": [
+ "defaultClientSettingOverrides",
"proxyAccountName",
"requireSetup",
"cacheRemoteFiles", |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14883 +/- ##
===========================================
+ Coverage 39.47% 41.02% +1.54%
===========================================
Files 1559 1565 +6
Lines 196944 203076 +6132
Branches 3616 3598 -18
===========================================
+ Hits 77747 83308 +5561
- Misses 118591 119158 +567
- Partials 606 610 +4 ☔ View full report in Codecov by Sentry. |
今まで内部的に持っていたデータがパブリックなものになると気軽に改修できなくなるから大変そう |
するなら抽象化レイヤーを挟んだ方が良さそう(既にそうなってるのかもしれないけど) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
packages/backend
Server side specific issue/PR
packages/frontend
Client side specific issue/PR
packages/misskey-js
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
defaultStore/coldDeviceStorageの生の値を変更できるように
(設定ごとのUIを用意しようと思うとものすごく大変なのでいったんこれで)
Why
Fix #12952
Fix #14436
Additional info (optional)
初期値変更によって動作がおかしくなった場所があるので確認中
Checklist