Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): ノートがログインしているユーザーしか見れない場合にログインをキャンセルした場合その後の動線がなくなる問題を修正 #15101

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

What

/notes/xxxyyyzzz ページで、

  • リモートに照会できるように
  • ログインをキャンセルするとトップページに飛ばすように

Why

ログインをキャンセルするとspinnerが表示されるだけの画面になり、読み込まれるかどうかが判別しにくいので

Additional info (optional)

トップページに飛ばすのはやや乱暴なので、エラー画面をちゃんと出すようにするとかでも良いかもしれない(ただしこの場合であっても別のページに抜けられる動線を置くべき)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 19.32%. Comparing base (074b7b0) to head (de67bd0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/note.vue 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15101       +/-   ##
============================================
- Coverage    39.98%   19.32%   -20.66%     
============================================
  Files         1563      728      -835     
  Lines       197746   103808    -93938     
  Branches      3647      991     -2656     
============================================
- Hits         79061    20066    -58995     
+ Misses      118081    83188    -34893     
+ Partials       604      554       -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit e8bf628 into misskey-dev:develop Dec 10, 2024
8 of 9 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 10, 2024

🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-lockdown-loginonly-behavior branch December 10, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants