Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): デッキでダブルクリックするとウィンドウが2枚開く問題を修正 #15105

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Dec 9, 2024

What

router遷移時に最初のクリックから300msは操作を抑止するようにした
dblclickclickの併用は無理みたい)

Why

Fix #14810

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 19.32%. Comparing base (074b7b0) to head (517b283).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/ui/deck.vue 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15105       +/-   ##
============================================
- Coverage    38.91%   19.32%   -19.59%     
============================================
  Files         1563      728      -835     
  Lines       197746   103810    -93936     
  Branches      3329      991     -2338     
============================================
- Hits         76960    20066    -56894     
+ Misses      120175    83190    -36985     
+ Partials       611      554       -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

ダブルクリックでウィンドウが2個起動しないようにする
1 participant