Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 絵文字管理画面で絵文字が表示されないことがある問題を修正 #15128

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

EmojiDetailedの画像URLをそのまま使うように(リモートはメディアプロキシ経由)

Why

Fix #15127

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 14, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 19.32%. Comparing base (e8bf628) to head (02ac187).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...kages/frontend/src/pages/custom-emojis-manager.vue 0.00% 3 Missing ⚠️
packages/frontend/src/pages/emoji-edit-dialog.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15128       +/-   ##
============================================
- Coverage    39.96%   19.32%   -20.64%     
============================================
  Files         1563      728      -835     
  Lines       197752   103809    -93943     
  Branches      3634      991     -2643     
============================================
- Hits         79031    20066    -58965     
+ Misses      118116    83189    -34927     
+ Partials       605      554       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 3e0fcae into misskey-dev:develop Dec 16, 2024
22 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 16, 2024

🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-15127 branch December 16, 2024 00:14
Ruruke pushed a commit to Ruruke/misskey that referenced this pull request Dec 16, 2024
* fix(frontend): 絵文字管理画面で絵文字が表示されないことがある問題を修正

* Update Changelog

* optimize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

96字以上のカスタム絵文字がコントロールパネル上だけ画像表示に失敗する
2 participants