Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): PC画面でチャンネルが複数列で表示されるように #15129

Merged

Conversation

kakkokari-gtyih
Copy link
Contributor

What

image

Why

たくさん表示できたほうがよいかも

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 14, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 19.26%. Comparing base (dac3b1f) to head (3bec197).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/channels.vue 0.00% 29 Missing ⚠️
...kages/frontend/src/components/MkChannelPreview.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15129       +/-   ##
============================================
- Coverage    38.91%   19.26%   -19.66%     
============================================
  Files         1563      728      -835     
  Lines       197745   103833    -93912     
  Branches      3330      992     -2338     
============================================
- Hits         76960    20002    -56958     
+ Misses      120174    83276    -36898     
+ Partials       611      555       -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 5a2b29a into misskey-dev:develop Dec 15, 2024
22 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 15, 2024

👍

@kakkokari-gtyih kakkokari-gtyih deleted the enh-channel-pagination-grid branch December 16, 2024 00:02
Ruruke pushed a commit to Ruruke/misskey that referenced this pull request Dec 16, 2024
* チャンネル一覧の列を最大3列にした (Otaku-Social#13)

* fix

* fix

* fix

* 🎨

* fix

* 🎨

* Update Changelog

* Update Changelog

* 要らない_marginを消す

---------

Co-authored-by: tmorio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

3 participants