Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): ドライブアップロード時に画像にウォーターマークを適用する機能 #15136

Draft
wants to merge 34 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

What

wip

Why

Fix #12250

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 14.67710% with 872 lines in your changes missing coverage. Please review.

Project coverage is 19.28%. Comparing base (e8bf628) to head (7c015b7).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...rontend/src/components/MkWatermarkEditorDialog.vue 0.00% 408 Missing and 1 partial ⚠️
packages/frontend/src/scripts/watermark.ts 41.25% 168 Missing ⚠️
.../src/components/MkWatermarkEditorDialog.anchor.vue 0.00% 93 Missing and 1 partial ⚠️
...src/components/MkWatermarkEditorDialog.padding.vue 0.00% 65 Missing and 1 partial ⚠️
packages/frontend/src/scripts/select-file.ts 21.21% 52 Missing ⚠️
packages/frontend/src/scripts/upload.ts 6.25% 15 Missing ⚠️
packages/frontend/src/pages/settings/drive.vue 0.00% 14 Missing ⚠️
packages/frontend/src/components/form/link.vue 0.00% 12 Missing ⚠️
packages/frontend/src/store.ts 0.00% 9 Missing ⚠️
packages/frontend/src/pages/admin/roles.vue 0.00% 8 Missing ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15136       +/-   ##
============================================
- Coverage    39.96%   19.28%   -20.69%     
============================================
  Files         1563      732      -831     
  Lines       197752   104787    -92965     
  Branches      3634      994     -2640     
============================================
- Hits         79031    20207    -58824     
+ Misses      118116    84023    -34093     
+ Partials       605      557       -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Dec 17, 2024

描画処理と設定UIは概ね完成した
後は保存処理とかアップロード時のウォーターマーク適用処理とか細かい部分とかを詰めればreadyできそう

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Dec 17, 2024

とりあえずひととおり動くようになった

FullHD画質の画像でアップロード前処理(ウォーターマーク+サイズ縮小)合計で1s位かかる
Web Workerで処理できるようになったら早められる?

@kakkokari-gtyih
Copy link
Contributor Author

処理というよりかはウォーターマーク画像のfetchに時間がかかっているだけの可能性はある

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

画像に自動でウォーターマークを付ける機能
2 participants