feat: replace global with globalThis #183
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globalThis
references with compatibilities:It's introduced from Node 12 (this plugin is Node >= 14) and it's the unified way to access the "global" object.
This has the benefit of making code more cross-platform and more consistent.
Old
New
Currently
globalThis
need to be pollyfilled in Karma context (tests fails).I did these tries but didn't work:
test
directory// /test/karma.config.js files: [ + 'test/polyfill-globalthis.js', 'node_modules/video.js/dist/video-js.css', 'dist/videojs-mobile-ui.css', 'node_modules/sinon/pkg/sinon.js', 'node_modules/video.js/dist/video.js', 'test/dist/bundle.js' ],
scripts
directory