Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tmp): use stdpath('cache') for tmp files #284

Merged
merged 13 commits into from
Oct 14, 2024

Conversation

gorillamoe
Copy link
Member

This should fix: #282

Maybe @Grueslayer can check if this also works on windows.

Basically put: if you can still see request responses it should work.

@gorillamoe gorillamoe added the bug Something isn't working label Oct 10, 2024
@gorillamoe gorillamoe self-assigned this Oct 10, 2024
@gorillamoe
Copy link
Member Author

Maybe also @willruggiano can check if this fixes the issue.

@willruggiano
Copy link

Yeah this resolves my original error. I've got a new error now which I'll create a separate issue for

@gorillamoe
Copy link
Member Author

Yeah this resolves my original error. I've got a new error now which I'll create a separate issue for

Should both work in this branch right now, fix for scratchpad is also in main, but I'll wait for having these fs changes tested on windows.

I'll try to have them tested in a docker container image from windows, let's see if I get this working 🤞

@gorillamoe
Copy link
Member Author

gorillamoe commented Oct 11, 2024

I'll try to have them tested in a docker container image from windows, let's see if I get this working 🤞

this is really complicated to get to work if you are used to the way linux / mac does the things.. so you need docker desktop and it needs to be running (neglecting the fact that docker desktop bugs me about creating an account every time I boot it up) and then you can run docker commands in powershell, but only if you have setup wsl2 correcly for which you need hyper-v enabled.. wtf?

I guess we get there, why is it like this? I mean why do we even need to have use docker on windows to build a docker container with windows? I mean it defeats the whole purpose imho 🤔

@gorillamoe
Copy link
Member Author

Quick update, got the container running with neovim and all stuff, but need to figure out a way to get the right luarocks version installed with busted in the right version 🤔

@gorillamoe
Copy link
Member Author

Now, that I got everything running in that windows container, I can throw it in the trash 🗑️, because GitHub doesn't support custom runners except ones that are based on Linux ..

I'm going to port this to a workflow file running windows-server2022.

@gorillamoe gorillamoe force-pushed the fix/tmp-path-for-ro-fs-envs branch 15 times, most recently from 924ec61 to 3eb2e5c Compare October 13, 2024 19:28
@gorillamoe gorillamoe force-pushed the fix/tmp-path-for-ro-fs-envs branch 3 times, most recently from 8492d6f to 38cf6ac Compare October 13, 2024 21:10
@gorillamoe gorillamoe merged commit c7a2c79 into main Oct 14, 2024
3 checks passed
@gorillamoe gorillamoe deleted the fix/tmp-path-for-ro-fs-envs branch October 14, 2024 01:08
iamxiaojianzheng pushed a commit to iamxiaojianzheng/kulala.nvim that referenced this pull request Oct 24, 2024
* fix(tmp): use `stdpath('cache')` for tmp files

This should fix: mistweaverco#282

* Add windows testrunner dockerfile

* fix(ci): workflow file

* refactor(ci): add optional windows test pipeline

* feat(ci): windows

* fix(fs): join_paths on windows

* fix(ci): windows cache

* fix(fs): gsub returns two params

* debug(ci): windows caching

* feat(tests): windows fs.join_paths

* refactor(ci): tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put scripts in a different (fs) location
2 participants