-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle throwable with null message in REPL #3081
base: ucr
Are you sure you want to change the base?
Conversation
*Fixes crash in a companion when a throwable is thrown with a null error message (runtime.scm) *Use newer API for AlertDialog.setButton() *Also change classes referencing RuntimeErrorAlert.alert()
Can one of the admins verify this patch? |
@AppInventorWorkerBee ok to test |
@XomaDev Note that because this affects companion behavior I have updated the base branch to |
Is there an AIA file that will demonstrate the issue? |
Using a newer API requires testing on older versions of Android that we still support. |
I just checked, and the use of a different API for setButton should be fine (as of API level 3). |
@SimpleFunction(description = "Does a crash")
public void Crash() throws Exception {
throw new Exception();
} |
...nventor/components/src/com/google/appinventor/components/runtime/util/RuntimeErrorAlert.java
Show resolved
Hide resolved
appinventor/buildserver/src/com/google/appinventor/buildserver/resources/runtime.scm
Show resolved
Hide resolved
appinventor/buildserver/src/com/google/appinventor/buildserver/resources/runtime.scm
Show resolved
Hide resolved
So now
|
https://github.com/mit-cml/appinventor-sources/blob/master/appinventor/buildserver/src/com/google/appinventor/buildserver/resources/runtime.scm#L419
Companion crashes where it fails to handle throwable with
null
error message, while this does not happen if the throwable has anempty
or non-null string.This happened at