Add mock preview support for extensions #3200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
shreyashsaitwal
force-pushed
the
gsoc/develop
branch
from
14871ff
to
a0abae4
Compare
shreyashsaitwal
force-pushed
the
gsoc/develop
branch
from
a0abae4
to
ea3cd91
Compare
Co-authored-by: Diego Barreiro Perez <[email protected]>
Co-authored-by: Diego Barreiro Perez <[email protected]>
barreeeiroo
reviewed
Aug 18, 2024
...tor/appengine/src/com/google/appinventor/client/editor/simple/components/MockButtonBase.java
Show resolved
Hide resolved
...ntor/appengine/src/com/google/appinventor/client/editor/simple/components/MockComponent.java
Show resolved
Hide resolved
| String packageName, | ||
| MockInfo mockInfo) { | ||
| super(editor, typeName, iconImage); | ||
| Ode.CLog("MockVisibleExtension.constructor"); |
There was a problem hiding this comment.
nit: we should remove these log statements before merging.
There was a problem hiding this comment.
Yes, this and a bunch of others need to go.
| Ode.CLog("MockVisibleExtension.initWorker"); | ||
| final String assetsBasePath = "assets/external_comps/" + packageName + "/"; | ||
|
|
||
| final Promise<String> fetchScript = fetchFileContent(assetsBasePath + mockInfo.getScript()); |
There was a problem hiding this comment.
What if the script is missing? How are we handling that case?
There was a problem hiding this comment.
We aren't handling that yet. Do you have any suggestions on how it should be handled?
...pengine/src/com/google/appinventor/client/editor/simple/components/MockVisibleExtension.java
Show resolved
Hide resolved
...pengine/src/com/google/appinventor/client/editor/simple/components/MockVisibleExtension.java
Outdated
Show resolved
Hide resolved
...pengine/src/com/google/appinventor/client/editor/simple/components/MockVisibleExtension.java
Show resolved
Hide resolved
...ngine/src/com/google/appinventor/client/editor/simple/palette/SimpleComponentDescriptor.java
Outdated
Show resolved
Hide resolved
appinventor/appengine/src/com/google/appinventor/client/utils/jstypes/WorkerOptions.java
Outdated
Show resolved
Hide resolved
shreyashsaitwal
changed the title
|
@AppInventorWorkerBee ok to test |
|
An example extension with mock can be found here. |
|
@jisqyv this is ready for review. |
|
Great work, as always. Is there a chance this will be included in the nb199 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for mock previews in extensions. Changes here are based on this design document.
Documentation for extension developers can be found here.