Fix bug where long directory names might not be null-terminated #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some versions of gcc, compiling
mkfs.c
fails because of thestringop-truncation
warning triggered by this line: https://github.com/mit-pdos/xv6-riscv/blob/riscv/mkfs/mkfs.c#L154.See gcc docs for an explanation of this warning. In short, if
shortname
is too long, the string in the direntry buffer will not be null-terminated.We fixed this by copying only the first
DIRSIZE - 1
bytes and setting the last byte to null.A similar case was found in
kernel/fs.c
where we can instead usesafestrcpy
.Please let me know if there is anything that we have overlooked.