temp fix for quitting on mac #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need backups
claudemuller
force-pushed
the
master
branch
2 times, most recently
from
5ef4ccd to
e3617b6
Compare
|
Hey @claudemuller, will you merge this, or fix it in a real way? |
|
Hey Lukas Unfortunately I couldn't merge your request as it still contains remnants of the purged files. I have however implemented your temporary solution for the quitting on OSX bug. Please confirm that it works. I'll work on this soon. |
|
I think it works. However when I follow the steps to build the app it creates an app that only says |
|
OK kewl, thanks. Yeah I did some work this morning around why the actual FTP side of things isn't working. I've reached a solution, just need to implement it. Keep yer eyes peeled :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not work, as the quit event from cmd + q and the menu action for close is blocked.
If you want this working you would need to distinguish between clicking the (x) on a window (and maybe add the cmd + w shortcut for this) and between closing the app
role:close.Reverting your change makes the app close on cmd + q, the menu item and the x on the window, which is better than the behaviour before. Especially since opening a new window results in the bug #4.