Skip to content

Commit

Permalink
Widen logging and add stack trace for IE selection bug
Browse files Browse the repository at this point in the history
Summary:
We are hoping to remove this flag that was meant to fix an IE selection bug. It
blocks selection events from being handled while React is rendering - the thing
is, this has never been a problem that we can see.

We are logging to see if real users actually hit this bug and if the flag
prevents a bad state in that case.

If we find that the flag is never hit, then it will soon be removed, unlocking
removal of a deprecated lifecycle method.

Reviewed By: sophiebits

Differential Revision: D6971850

fbshipit-source-id: 8874b21161de3b3f0f568baca2a8c0278b01fa54
  • Loading branch information
flarnie authored and facebook-github-bot committed Feb 13, 2018
1 parent e65a8e6 commit a6317e6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/component/handlers/edit/editOnSelect.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function editOnSelect(editor: DraftEditor): void {
DraftJsDebugLogging.logBlockedSelectionEvent({
// For now I don't think we need any other info
anonymizedDom: 'N/A',
extraParams: '',
extraParams: JSON.stringify({stacktrace: new Error().stack}),
selectionState: JSON.stringify(selectionState.toJS()),
});
}
Expand Down

0 comments on commit a6317e6

Please sign in to comment.