Feature/tree #43
Open
Feature/tree #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decode "blocks" from RawContentState Add base for tree example Add base for component DraftEditorBlocks Change blockList to blockMap in ContentBlock Extend DraftOffsetKeyPath format Switch to keep a flatten map of blocks in ContentState Adapt splitBlockInContentState to split in the same parent
Allowing nested blocks component to update blocks that have nesting Adding rich text integration to the tree demo Added tables to the example so that we can prove the tree mapping - included basic table to prove we can edit inside table, also integrating blockRenderMap
Improve content of tree example Add NestedUtil and handle Enter+Shift Fix some flow types
- making nestingEnabled option configurable - making sure the convertFromRaw is aware of nesting Making sure that nesting is based on the parentBlock as opposed to the current element
Adding basic input to the example for quick testing Fixing setHtml for table Converted initial data to use html instead of raw content blocks Fixing pasting - making sure we can paste contents copied from the editor itself Adding thead definition
Create nested block as unstyled by default Split block as nested if pressing enter in a block with nested blocks Fix #13: only display text when block don't have nested blocks Add keys utility function "generateNestedKey" Adapt splitNestedBlockInContentState to create 2 nested unstyled blocks Use NestedUtils.keyBinding in tree example Fix flow error in component/contents/DraftEditorBlock.react.js Fix flow error in model/encoding/convertFromHTMLToContentBlocks.js
Fixing pasting for root elements WIP - Fixing flow definitions Fixing flow definition Fixing eslint Fixing several bugs Fixing pasting bugs Fixing tests for pasting Fixing tests for DraftEditorBlock Fixing linting Fixing travis Adding tests for nested blocks on paste processor Fixing selection invariation bug
Fix #17: expose DefaultBlockRenderMap for NestedUtils Fix value of NestedUtils. DefaultBlockRenderMap Add unit tests for "ContentState.getBlockChildren" Add unit tests for "ContentState.getFirstLevelBlocks" Add test for "splitBlockWithNestingInContentState" Add test for getParentKey of contentBlock Correctly handle pressing enter in an empty nested block Fix flow error in ContentBlock Only split parent block if last child
- WIP Fixing the demo - using the nestedBlockRenderMap but still having to include extra nesting on some blocks Fixing demo Making paste processor not create unstyed blocks by default
Minor fix on pasting Started working with the backspace behaviour - implementing backspace - fixed selection behaviour Integrating BACKSPACE logic for nested blocks Integrating DELETE logic for nested blocks Integrating toolbar to support nested elements Minor fix Modifying the split parent Updating behaviour for split text - by default enter should always create a new line even when inside h1 on lists Making sure that the split behaviour is correct
Fixing split behaviour on nested and non nested blocks Making sure that we get a valid nested set of elements via getContentStateFragment - making sure it preserves nesting Fixing logic for finding adjacent leaves Removing tables from the tree example Preserving parent wrapper time
Refactoring and minor fixes - making sure that we can generate random nested keys when inserting and getting fragments Adding tests - Adding test coverage Fixing linting Refactoring NestedTextEditorUtils and making methods exposed in order to allow unit testing - Refactoring and exposing methods for testing Adding tests for NestedTextEditorUtils and fixing a list bug Adding test coverage for NestedTextEditorUtils w Fixing atomic utils compatibility with nesting blocks Fixing convertToHTML new blocks nesting bug and adding tests for it Fixing list toggle type
- making sure we do not compute the blockChildren unless needed
…s even key is defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping this open for referencing, this is just the old PR open to a branch that maches the previous master