Refactored schedule tree #169

amir-qayyum-khan · 2016-01-04T14:45:00Z

Background

fixes #146, fixes #165, fixes #54, fixes #39

What is done in this PR

Studio Updates: None.
LMS Updates:

Refactored schedule page to use full potential of backbonejs
Now schedule tree will not collapse after setting dates or removing child.

Detail:

User can see start or due date on schedule tree.
User can remove a unit (can be chapter, subsection or vertical) from tree. By doing so we will hide this component along with children by setting `hidden=true``
Added validation on changing start or due date on schedule tree.
The units with hidden=false is shown to schedule tree on left size, the units with hidden=true is supplied to form at right side. From there user can change visibility of hidden units by clicking Adding a unit or Adding all units
Added validation on start and due date in form.
In this refactoring I moved possible code to template.underscore files.
Made custom view for tree, right container, set date button
ccx_schedule.js is the main view. It saves, edit, update collection and renders other view

@pdpinch @giocalitri

pdpinch · 2016-01-04T15:20:16Z

@justinabrahms this is the Backbone PR I mentioned in stand-up.

The original JavaScript was done by a contractor who is long gone. DB didn't like it, which was making it hard for us to make modifications.

justinabrahms · 2016-01-04T15:25:01Z

@amir-qayyum-khan Can you comment more on what specifically was refactored? I'm not clear what you mean by realizing the "full potential of backbone". I would expect more code deletion as part of this refactoring.

justinabrahms · 2016-01-04T15:33:52Z

lms/static/js/ccx/view/ccx_schedule.js

+
+        // This data will be render on schedule tree.
+        this.scheduleTreeData = this.pruned(scheduleJson, function(node) {
+          return !node.hidden;


Should this also be excluding on vertical?

justinabrahms · 2016-01-04T15:38:28Z

lms/static/js/ccx/view/schedule_tree.js

+        var ccxScheduleTreeNode = new scheduleTreeNode.
+          ccxScheduleTreeNodeView({ model: chapter });
+        ccxScheduleTreeNode.render();
+        this.$el.append(ccxScheduleTreeNode.el);


Instead of manually altering the DOM, consider a template.

justinabrahms · 2016-01-04T16:11:58Z

In general, it would be good to add some documentation about what these modules are for and how they're outlined. I found myself wondering how this stuff all fit together.

amir-qayyum-khan · 2016-01-07T14:24:54Z

@justinabrahms can you please review ?

…se links

REST APIs modified

…paced-subsection-config Fix subsection config for self-paced course

…ctoring_0_12_11 Incremented edx-proctoring version to 0.12.11

MA-1919 making mobile handout links accommodate jump to id's and cour…

@efischer19

…eplay) The get_or_create function is vulnerable to race conditions in MySQL, which can cause the model LoginFailure to, in some cases, have more than one row for the same user, breaking the login for that user. Addinf functionality to expect and clean the error by deleting extra rows (by oldest lockout date), leaving just one entry and allowing the user to login. Replayed and squashed by @efischer19, initially commited by @laq

@efischer19

Replayed by @efischer19 due to git issues, initially commited by @laq

Upgrade edx-lint to 0.4.2

Added extra field to CCX model for Course Models

Avoid MultipleObjectsReturned errors with LoginFailures

Syncs preface with edx-doc repo version

SECURITY FIX : Fix CAPA Problems

amir-qayyum-khan added the in progress label Jan 4, 2016

amir-qayyum-khan changed the title ~~Refactored schedule tree~~ WIP Refactored schedule tree Jan 4, 2016

amir-qayyum-khan added the CCX label Jan 4, 2016

amir-qayyum-khan force-pushed the refactor/aq/schedule.js branch from ba92e47 to ee34a86 Compare January 4, 2016 15:02

justinabrahms reviewed Jan 4, 2016
View reviewed changes

amir-qayyum-khan force-pushed the refactor/aq/schedule.js branch from ee34a86 to faf297f Compare January 4, 2016 15:37

justinabrahms reviewed Jan 4, 2016
View reviewed changes

pdpinch assigned justinabrahms Jan 4, 2016

amir-qayyum-khan force-pushed the refactor/aq/schedule.js branch 5 times, most recently from 4dc8c3a to 017a697 Compare January 7, 2016 14:20

amir-qayyum-khan changed the title ~~WIP Refactored schedule tree~~ Refactored schedule tree Jan 7, 2016

amir-qayyum-khan added Needs Review and removed in progress labels Jan 7, 2016

amir-qayyum-khan force-pushed the refactor/aq/schedule.js branch from 017a697 to 5512b3f Compare January 7, 2016 14:58

amir-qayyum-khan force-pushed the refactor/aq/schedule.js branch from d9519ee to 1351170 Compare February 25, 2016 14:44

MA-1919 making mobile handout links accommodate jump to id's and cour…

75a26b6

…se links

amir-qayyum-khan force-pushed the refactor/aq/schedule.js branch from 1351170 to dc6b19a Compare February 25, 2016 15:23

Giovanni Di Milia and others added 23 commits February 25, 2016 10:27

Added extra field to CCX model for Course Models

0c637cd

REST APIs modified

Use edx-lint 0.4.2

3fa573d

Merge pull request openedx#11597 from edx/mushtaq/ECOM-3760-fix-self-…

78b6983

…paced-subsection-config Fix subsection config for self-paced course

Merge pull request openedx#11659 from edx/douglashall/release_edx_pro…

4bad888

…ctoring_0_12_11 Incremented edx-proctoring version to 0.12.11

Merge pull request openedx#11602 from edx/sstudent/MA-1919

c518543

MA-1919 making mobile handout links accommodate jump to id's and cour…

Add laq in Authors List (replay)

8442e4d

Replayed by @efischer19 due to git issues, initially commited by @laq

Syncs preface and browsers file with edx-doc repo version

8057903

Merge pull request openedx#11610 from edx/ned/edx-lint-0.4.2

c913734

Upgrade edx-lint to 0.4.2

Merge pull request openedx#11356 from mitocw/gdm_ccx_course_modules_#170

3be2737

Added extra field to CCX model for Course Models

Merge pull request openedx#11658 from edx/laq/multiple_login_failures

adb8896

Avoid MultipleObjectsReturned errors with LoginFailures

Merge pull request openedx#11649 from edx/ahodges/DOC-2720p

4653301

Syncs preface with edx-doc repo version

Refactored schedule tree

b4927e0

Removed content from main.js, they are useless

30177a9

removed redundent function

f00c87f

Fixed issues on justion feedback 7 jan

2331fb0

Removed parent view reference to avoide coupling

43ccad9

Moved some functionality to collection file

5237c8f

Remove unsued imports

c304301

fix minor issues

8a49ee2

Added test suit.

f678f84

Fixed quality issues

e315e45

Fixed pyton test case related to schedule

02be0e3

amir-qayyum-khan force-pushed the refactor/aq/schedule.js branch from dc6b19a to 02be0e3 Compare February 26, 2016 11:51

amir-qayyum-khan closed this Mar 1, 2016

pdpinch removed this from the Feb 1 milestone Mar 2, 2016

emZubair pushed a commit that referenced this pull request Sep 30, 2020

Merge pull request #169 from edx/aj/sec-fix-capa

eaaebc6

SECURITY FIX : Fix CAPA Problems

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactored schedule tree #169

Refactored schedule tree #169

amir-qayyum-khan commented Jan 4, 2016

pdpinch commented Jan 4, 2016

justinabrahms commented Jan 4, 2016

justinabrahms Jan 4, 2016

justinabrahms Jan 4, 2016

justinabrahms commented Jan 4, 2016

amir-qayyum-khan commented Jan 7, 2016

Refactored schedule tree #169

Refactored schedule tree #169

Conversation

amir-qayyum-khan commented Jan 4, 2016

Background

What is done in this PR

Detail:

pdpinch commented Jan 4, 2016

justinabrahms commented Jan 4, 2016

justinabrahms Jan 4, 2016

Choose a reason for hiding this comment

justinabrahms Jan 4, 2016

Choose a reason for hiding this comment

justinabrahms commented Jan 4, 2016

amir-qayyum-khan commented Jan 7, 2016