Fixed calculation of max_pts for problems which are not attempted yet #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amir-qayyum-khan
changed the title
amir-qayyum-khan
force-pushed
the
fix/aq/max_points_grades_mitocw#147
branch
from
b6796a4
to
25f401c
Compare
pdpinch
changed the title
|
I made some edits to the title & description |
|
The diff is a lot larger than I expected. Is it being compared to the right branch? |
|
@pdpinch I compare it to my branch, the same branch against which @pwilkins was reviewing my PR #190. Plus I verified code to make sure it is not change on edx master https://github.com/edx/edx-platform/blob/master/lms/djangoapps/courseware/grades.py#L385-L403 |
amir-qayyum-khan
force-pushed
the
fix/aq/max_points_grades_mitocw#147
branch
3 times, most recently
from
149150c
to
c338d8b
Compare
amir-qayyum-khan
force-pushed
the
enhancement/aq/add_normalization_info_lagacy_dashboard_remote_gradebook_mitocw#147
branch
from
71fd151
to
4328dbb
Compare
|
Dave explained that this was done this way for performance reasons. He suggested we look at how this is handled in the progress_summary instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
connected to #190
graded_total = Score(0.0, 1.0, True, section_name, None)https://github.com/edx/edx-platform/blob/master/lms/djangoapps/courseware/grades.py#L461
score/max-scoreand for students who did not attempted the same problem the score will be0/1.0/1looks like normalize grade, and whole grade sheet look like mixture of normalize and non-normalize grades.What is done in this PR
Studio Updates: None
LMS Updates:
0/max score.cc @pdpinch @pwilkins
@pdpinch as we discussed yesterday. you told me to create Pr for ormsbee. So that you can discuss with him.
After solution: