Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: revert to upstream approach to use logo url #46

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

mudassir-hafeez
Copy link
Contributor

What are the relevant tickets?

Following up https://github.com/mitodl/hq/issues/3337#issuecomment-2357798696.

Description (What does it do?)

This PR reverts to the upstream approach for using the logo URL, as the upstream PR and its backport have been merged.

Screenshots (if appropriate):

image

How can this be tested?

  • Ensure the mitxonline-theme is configured.
  • Set LOGO_URL_PNG_FOR_EMAIL in the settings/private.py file.
  • Verify that emails sent via batch enrollment use the value set in LOGO_URL_PNG_FOR_EMAIL

Additional Context

  • We might not need to manually set LOGO_URL_PNG_FOR_EMAIL, as it appears to be already set here for all instances.

Copy link
Contributor

@asadali145 asadali145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mudassir-hafeez mudassir-hafeez merged commit eb74dc8 into main Sep 18, 2024
1 check passed
@mudassir-hafeez mudassir-hafeez deleted the mudassir/revert-upstream-approach branch September 18, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants