Skip to content

Commit

Permalink
sd_ass: remove unneeded ontop variable
Browse files Browse the repository at this point in the history
Missed in 3250f6e. Note that the
hardcoded ass alignment value is not used anymore as of that commit, but
we should ideally be moving towards secondary subs actually being
customizable via ASS anyways.
  • Loading branch information
Dudemanguy committed Dec 16, 2023
1 parent b0f31a7 commit 1112de2
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions sub/sd_ass.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ struct sd_ass_priv {
struct sd_filter **filters;
int num_filters;
bool clear_once;
bool on_top;
struct mp_ass_packer *packer;
struct sub_bitmap_copy_cache *copy_cache;
char last_text[500];
Expand Down Expand Up @@ -562,8 +561,7 @@ static struct sub_bitmaps *get_bitmaps(struct sd *sd, struct mp_osd_res dim,
{
struct sd_ass_priv *ctx = sd->priv;
struct mp_subtitle_opts *opts = sd->opts;
bool no_ass = !opts->ass_enabled || ctx->on_top ||
opts->ass_style_override == 5 || order == 1;
bool no_ass = !opts->ass_enabled || opts->ass_style_override == 5 || order == 1;
bool converted = ctx->is_converted || no_ass;
ASS_Track *track = no_ass ? ctx->shadow_track : ctx->ass_track;
ASS_Renderer *renderer = ctx->ass_renderer;
Expand Down Expand Up @@ -786,9 +784,6 @@ static void fill_plaintext(struct sd *sd, double pts)

bstr dst = {0};

if (ctx->on_top)
bstr_xappend(NULL, &dst, bstr0("{\\a6}"));

while (*text) {
if (*text == '{')
bstr_xappend(NULL, &dst, bstr0("\\"));
Expand Down

0 comments on commit 1112de2

Please sign in to comment.