Skip to content

Commit

Permalink
js: complex key-binding: send also key_text
Browse files Browse the repository at this point in the history
This is doumented and has been part of the table in lua, but until
now not in the JS object.

Fixes mpv-player#13448
  • Loading branch information
avih committed Feb 9, 2024
1 parent a45518c commit d70c77b
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions player/javascript/defaults.js
Original file line number Diff line number Diff line change
Expand Up @@ -246,10 +246,10 @@ mp.get_osd_margins = function get_osd_margins() {
// {cb: fn, forced: bool, maybe input: str, repeatable: bool, complex: bool}
var binds = new_cache();

function dispatch_key_binding(name, state, key_name) {
function dispatch_key_binding(name, state, key_name, key_text) {
var cb = binds[name] ? binds[name].cb : false;
if (cb) // "script-binding [<script_name>/]<name>" command was invoked
cb(state, key_name);
cb(state, key_name, key_text);
}

var binds_tid = 0; // flush timer id. actual id's are always true-thy
Expand Down Expand Up @@ -307,11 +307,12 @@ function add_binding(forced, key, name, fn, opts) {
fn({event: "press", is_mouse: false});
});
var KEY_STATES = { u: "up", d: "down", r: "repeat", p: "press" };
key_data.cb = function key_cb(state, key_name) {
key_data.cb = function key_cb(state, key_name, key_text) {
fn({
event: KEY_STATES[state[0]] || "unknown",
is_mouse: state[1] == "m",
key_name: key_name || undefined
key_name: key_name || undefined,
key_text: key_text || undefined
});
}
} else {
Expand Down

0 comments on commit d70c77b

Please sign in to comment.