fix: allow getShorthandAttrValue to parse borders (#2729)

* fix: allow getShorthandAttrValue to parse borders * Updated column to use getShorthandBorderValue
mjmlio · Sep 11, 2023 · 50cd15b · 50cd15b
1 parent a61b973
commit 50cd15b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/mjml-column/src/index.js b/packages/mjml-column/src/index.js
@@ -40,8 +40,8 @@ export default class MjColumn extends BodyComponent {
     const { nonRawSiblings } = this.props
     const { borders, paddings } = this.getBoxWidths()
     const innerBorders =
-      this.getShorthandAttrValue('inner-border', 'left') +
-      this.getShorthandAttrValue('inner-border', 'right')
+      this.getShorthandBorderValue('left', 'inner-border') +
+      this.getShorthandBorderValue('right', 'inner-border')
 
     const allPaddings = paddings + borders + innerBorders
 

diff --git a/packages/mjml-core/src/createComponent.js b/packages/mjml-core/src/createComponent.js
@@ -128,10 +128,10 @@ export class BodyComponent extends Component {
     return shorthandParser(mjAttribute, direction)
   }
 
-  getShorthandBorderValue(direction) {
+  getShorthandBorderValue(direction, attribute = 'border') {
     const borderDirection =
-      direction && this.getAttribute(`border-${direction}`)
-    const border = this.getAttribute('border')
+      direction && this.getAttribute(`${attribute}-${direction}`)
+    const border = this.getAttribute(attribute)
 
     return borderParser(borderDirection || border || '0')
   }