-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [Draft] Bump PHP to 8.1 & Symfony to 5.4 plus dependencies #90
Open
jefferya
wants to merge
18
commits into
mjordan:main
Choose a base branch
from
jefferya:jefferya/php_8.1_syfony_5.4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mand\ContainerAwareCommand"
jefferya
force-pushed
the
jefferya/php_8.1_syfony_5.4
branch
from
January 19, 2023 22:48
39eae4f
to
8cf4c59
Compare
* Removing the security.yaml file as security is not enabled, at present, and I'm not sure how to do the equivalent in the new authenticator component * Deprecate FirewallConfig::allowsAnonymous() and the allows_anonymous from the data collector data, there will be no anonymous concept as of version 6 - https://github.com/symfony/security-bundle/blob/5.4/CHANGELOG.md. * Since symfony/security-core 5.4: The "Symfony\Component\Security\Core\Authentication\Token\AnonymousToken" class is deprecated. * Since symfony/security-bundle 5.3: The "security.authentication.listener.anonymous.main" service is deprecated, use the new authenticator system instead * "Since symfony/security-bundle 5.3: The \"security.authentication.manager\" service is deprecated, use the new authenticator system instead"
…ice" service is deprecated, use "session.storage.factory.native", "session.storage.factory.php_bridge" or "session.storage.factory.mock_file" instead.
* RouteCollectionBuilder deprecated * Bump Symfony components * Since symfony/framework-bundle 5.1: Using type \"Symfony\\Component\\Routing\\RouteCollectionBuilder\" for argument 1 of method \"App\\Kernel:configureRoutes()\" is deprecated, use \"Symfony\\Component\\Routing\\Loader\\Configurator\\RoutingConfigurator\" instead. * "Symfony\Component\HttpKernel\KernelInterface::registerBundles()" might add "iterable" as a native return type declaration in the future. Do the same in implementation "App\Kernel" now to avoid errors
jefferya
force-pushed
the
jefferya/php_8.1_syfony_5.4
branch
from
March 9, 2023 00:45
dcd307f
to
788eebc
Compare
… if no media source field found.
…erya/php_8.1_syfony_5.4
…recated" messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-progress.
The problem: update to PHP 8 and Symfony 5.4 LTS versions (plus dependancies) and remove deprecation messages
What has been tested
The testing infrastructure is defined: in https://github.com/cwrc/isle-bagger which builds upon an Isle Buildkit PHP 8.1 container (unreleased as of 2023-01-19) -- see the aforementioned link for details.
Todo: