Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various suggestions #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Various suggestions #113

wants to merge 1 commit into from

Conversation

asarhaddon
Copy link
Contributor

Hello.
This merge request mixes a few subjects, but I only expect the fourth commit to contain controversial changes (I am not sure for the removal of the travis test, for example).
Please tell me which parts should be in a separate request, if any.
With these changes, the Debian package passes the tests in the build tree, but also test/run-tests.sh --prog=whitakers-words --datadir=/usr/share/whitakers-words after installation.
The third patch fixes an error detected by the command above.
Thanks.

@mk270
Copy link
Owner

mk270 commented Oct 28, 2020

Thanks once again!

I've merged the first three of these (and yes, ideally submit changes lacking logical interdependencies as separate pull requests - this makes it easier to interleave merges with other branches, which is ongoing problem)

I'll have a look at the test script improvements shortly

@asarhaddon
Copy link
Contributor Author

Hi.
Despite its name, this merge request now only affects the test script.
It would be convenient for the Debian packagers to know which part of this request you find interesting, even if it is not actually merged yet.
(in case you are curious: git can rename files but the package internals use plain patches).

@mk270
Copy link
Owner

mk270 commented Feb 20, 2023

I don't think the software is DFSG-free; I think Debian has rejected it on that basis in the past, TICBW.

@mk270
Copy link
Owner

mk270 commented Feb 20, 2023

(this is of course no reason NOT to do good software engineering!)

@asarhaddon
Copy link
Contributor Author

As far as I remember, LICENSE.txt was problematic because of the you can sell it as your own, but at least tell me restriction, which is stricto sensu not compatible with the DFSG.

This restriction arguably made sense while the author was alive, but quotes on the Notre Dame website show that his intent was not to forbid commercial use in the future.

Debian has found this convincing and has been distributing a whitakers-words package for more than two years.

Of course, now that you are the only maintainer and the Notre Dame website does not distribute this software or related quotes anymore, it would be nice to make your LICENSE.txt more explicit.

@calumapplepie will probably have more accurate memories.

(I do not understand TICBW)

@calumapplepie
Copy link
Contributor

#118 documents the problem; @asarhaddon 's memories are accurate, though. #118 has the continuation of this discussion; the Debian package's distribution is based on a license formed from the contents of the now-defunt website, as the current LICENSE.TXT is, in fact, non-free.

@asarhaddon

This comment was marked as outdated.

@asarhaddon
Copy link
Contributor Author

This merge request is now focused on the test script.

Show details after failed tests, and a final summary.

Display all available information for failed tests (not only in travis).

Stop removing the last line. The header pollutes the diff, but the
last line does’t change often.
Also, testing it makes sense in interactive mode.

Move the smoke test into its own directory.
@asarhaddon
Copy link
Contributor Author

This rebase adapts the english test, which has been merged meanwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants