Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reason dependency #181

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Update reason dependency #181

merged 3 commits into from
Nov 13, 2024

Conversation

pedrobslisboa
Copy link
Collaborator

@pedrobslisboa pedrobslisboa commented Nov 4, 2024

Description

This PR updates the reason to 3.11.0 and higher and formats the files.
It attempts to solve the format issues on CI that required us to fix the reason to 3.10.0.

@davesnx after I cleaned the opam cache and update to 3.11.0 I was able to run make format and see the output we have in this PR.

I have to say that one of the changes was strange to me, the change to raw:

- let%browser_only mockInitWebsocket = () => [%mel.raw
+ let%browser_only mockInitWebsocket = () =>
+  {%mel.raw |
    function mockInitWebsocket() {
      console.log("Load JS");
    }
- |}
- ];
+ |};

I don't know if we want to have or change this in some way.

Why to have this PR?

In theory, this PR will let us continue without the reason dep blocked.
And then let us, for example, to update server-reason-react on styled-ppx
Captura de Tela 2024-11-04 às 19 59 39

@pedrobslisboa pedrobslisboa force-pushed the feat/update-reason-dep branch 2 times, most recently from 5bb4dfb to 2e943eb Compare November 4, 2024 20:39
@pedrobslisboa pedrobslisboa self-assigned this Nov 4, 2024
@pedrobslisboa pedrobslisboa force-pushed the feat/update-reason-dep branch 2 times, most recently from e19d823 to 0dd1ed2 Compare November 4, 2024 21:00
@pedrobslisboa pedrobslisboa force-pushed the feat/update-reason-dep branch 2 times, most recently from 87f22bd to 4d02af4 Compare November 4, 2024 22:18
@pedrobslisboa pedrobslisboa force-pushed the feat/update-reason-dep branch from 4d02af4 to 2136bb3 Compare November 4, 2024 22:36
@pedrobslisboa pedrobslisboa marked this pull request as ready for review November 4, 2024 23:00
@davesnx davesnx merged commit 61e1f6a into main Nov 13, 2024
2 checks passed
@davesnx davesnx deleted the feat/update-reason-dep branch November 13, 2024 16:53
davesnx added a commit that referenced this pull request Nov 13, 2024
… into rsc

* 'main' of github.com:ml-in-barcelona/server-reason-react:
  Update reason dependency (#181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants