Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor state.dart file #556

Open
d-uzlov opened this issue Oct 3, 2022 · 0 comments
Open

Refactor state.dart file #556

d-uzlov opened this issue Oct 3, 2022 · 0 comments
Assignees
@anhappdev
Labels
size:medium requires 3-5 days type:refactoring No functional changes needed but code quality/readability is affected

Comments

@d-uzlov
Copy link
Contributor

d-uzlov commented Oct 3, 2022

In previous refactoring we skipped the state.dart file.
https://github.com/mlcommons/mobile_app_open/blob/b8c37441fb513a5c3425af37560d0064c27ff445/flutter/lib/benchmark/state.dart

Currently this file has several responsibilities and it's quite big, so we should spend some time refactoring it to make other tasks easier and reduce possibility of introducing bugs.
@d-uzlov d-uzlov added type:refactoring No functional changes needed but code quality/readability is affected size:medium requires 3-5 days labels Oct 3, 2022
@d-uzlov d-uzlov self-assigned this Oct 3, 2022
This was referenced Oct 26, 2022
Merged
Closed
@anhappdev anhappdev assigned anhappdev and unassigned d-uzlov Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anhappdev anhappdev

Labels
size:medium requires 3-5 days type:refactoring No functional changes needed but code quality/readability is affected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor state.dart (part 2) mlcommons/mobile_app_open
2 participants
@d-uzlov @anhappdev