Refactor state.dart (part 2) #596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
d-uzlov
commented
Oct 30, 2022
Comment on lines
+93
to
+101
| // All methods in AppState should have the following properties: | ||
| // - Public methods: return type `void`, public methods must not be awaited | ||
| // - Public methods: exceptions are never thrown | ||
| // - All methods: notifyListeners() call outside of `state` setter is forbidden | ||
| // - All methods: if notifyListeners() is needed when `state` field doesn't change, | ||
| // the class that contains the data that requires UI update should implement ChangeNotifier instead | ||
| // - All methods: complex logic should be moved to other classes, methods in AppState should only manage `state` | ||
| // | ||
| // Any methods or getters that don't satisfy these requirements should be subject to refactoring. |
There was a problem hiding this comment.
@anhappdev, the #556 issue and this whole PR in particular was for these rules.
Other changes may be subject to discussions, but I think these few lines are very important.
Everything else in this PR was changed to make this possible. Even though there are still few little things left in this class that don't obey these rules, now it will be easy to fix it.
…ctor-state-2 # Conflicts: # flutter/lib/state/task_runner.dart
|
Kudos, SonarCloud Quality Gate passed!
|
|
close this for now. We prefer piecemeal changes. Maybe we can cherrypick some small ones from this huge one later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #556
This is a huge pull request, which is not ideal.
If I had enough time I would split it into several small PRs which would be much easier to review.
However, I think it's very important to merge it. I believe that this PR contains a significant code quality improvement (which I was thinking about for the last several months).