Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial import from original repo #2

Merged
merged 95 commits into from
Oct 1, 2024
Merged

Initial import from original repo #2

merged 95 commits into from
Oct 1, 2024

Conversation

jgiannuzzi
Copy link
Collaborator

This PR imports the current state of the code from the original repo at https://github.com/jgiannuzzi/mlflow-go. I tried my best to preserve all the proper attributions (authors, dates, sign-offs) and also added links to the original PRs for historical context.

jgiannuzzi and others added 30 commits June 24, 2024 17:35
@jgiannuzzi
Initial commit
1f0266d 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Configure ruff further
cc1adf2 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Import Go code and misc settings
d5f6cbd 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Add README with a few rewrites
bb4148a 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Move Go commands under cmd
6096fe4 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Add ModelRegistry GetLatestVersions endpoint
861e7d7 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@nojaf
Initial generation of Go files from proto
dbc7351 
jgiannuzzi/mlflow-go#1

Signed-off-by: nojaf <[email protected]>
@jgiannuzzi
Update gitignore
044eaba 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Use snake case for JSON
c6cde6c 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Make the server work again
7745759 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Miscealenous binding improvements
424d844 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Add current FFI definitions
2b10c0c 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Fix Go compilation on Windows
13d102d 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@nojaf
Use logrus logger
85339b3 
jgiannuzzi/mlflow-go#2

Signed-off-by: nojaf <[email protected]>
@jgiannuzzi
Stop the entire process group when stopping the Python command
7f7838c 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Move Go and Python files in separate directories at the top-level
726af02 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Fix typo in README
af8ab6b 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@nojaf
Mage
a7dbb82 
jgiannuzzi/mlflow-go#3

Signed-off-by: nojaf <[email protected]>
@jgiannuzzi
Keep Go cache across devcontainer rebuilds
9d8150d 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Monkey eats banana
e595a08 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Extra logging to know when Go/Python server exits
f9c9e44 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Allow passing python_address and python_command to the Go server
fcb71f9 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Use MLFlow's find_free_port function
eb9e8f4 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Run unmodified server tests
091cd72 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Improve build process
f27c4fd 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Improve temporary doc
7e852ed 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@nojaf
Moar mage targets
2e1daf9 
jgiannuzzi/mlflow-go#4

Signed-off-by: nojaf <[email protected]>
@jgiannuzzi
Update repo.go
d4b8731 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Run go mod tidy
51e4b3a 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
@jgiannuzzi
Use real sqlite instead of wasm one now that we use cgo
77b045a 
Signed-off-by: Jonathan Giannuzzi <[email protected]>
dsuhinin and others added 19 commits September 9, 2024 14:04
@dsuhinin
Finish run endpoints migration
1c003a5 
jgiannuzzi/mlflow-go#29

Signed-off-by: Software Developer <[email protected]>
@nojaf
Fix test_log_batch_nonexistent_run
a0d5100 
jgiannuzzi/mlflow-go#30

Signed-off-by: nojaf <[email protected]>
@nojaf
Truncate in validation
7a4e2e1 
jgiannuzzi/mlflow-go#24

Signed-off-by: nojaf <[email protected]>
@nojaf
Force DeletedTime to be NULL
b932dc4 
jgiannuzzi/mlflow-go#34

Signed-off-by: nojaf <[email protected]>
@nojaf
Set DeletedTime for Runs to NULL when restoring experiment.
4351268 
jgiannuzzi/mlflow-go#35

Signed-off-by: Florian Verdonck <[email protected]>
@nojaf
Return None for empty next_page_token
5e3860f 
jgiannuzzi/mlflow-go#36

Signed-off-by: Florian Verdonck <[email protected]>
@nojaf
Take valid stages into account
3db35cb 
jgiannuzzi/mlflow-go#31

Signed-off-by: Florian Verdonck <[email protected]>
@nojaf
Check if run is active in log metrics.
522834f 
jgiannuzzi/mlflow-go#37

Signed-off-by: Florian Verdonck <[email protected]>
@dsuhinin
Unify work with protos, models, entities.
79dac8c 
jgiannuzzi/mlflow-go#32

Signed-off-by: Software Developer <[email protected]>
@nojaf
Return contract errors for attribute filter validation.
a331064 
jgiannuzzi/mlflow-go#38

Signed-off-by: Florian Verdonck <[email protected]>
@nojaf
Return correct error message for logBatch uniqueParams
6c278ee 
jgiannuzzi/mlflow-go#39

Signed-off-by: Florian Verdonck <[email protected]>
@nojaf
Ignore test via conftest
ca95e7e 
jgiannuzzi/mlflow-go#40

Signed-off-by: Florian Verdonck <[email protected]>
@dsuhinin
Normalise models, protos, entities. simplify logic.
8eaf2c1 
jgiannuzzi/mlflow-go#41

Signed-off-by: Software Developer <[email protected]>
@nojaf
Test search runs datasets
3cd9545 
jgiannuzzi/mlflow-go#42

Signed-off-by: Florian Verdonck <[email protected]>
@nojaf
Use correct validation error for max length
a7addb9 
jgiannuzzi/mlflow-go#33

Signed-off-by: Florian Verdonck <[email protected]>
@nojaf
Port extact AppendToURIPath function from Python
c538f78 
jgiannuzzi/mlflow-go#43

Signed-off-by: Florian Verdonck <[email protected]>
@nojaf
Allow endtime to be NULL in update run
bdf8178 
jgiannuzzi/mlflow-go#44

Signed-off-by: Florian Verdonck <[email protected]>
@nojaf
Test order by metric tag param
258a61e 
jgiannuzzi/mlflow-go#46

Signed-off-by: Florian Verdonck <[email protected]>
@dsuhinin
Trying to fix issue with NaN, Inf, -Inf
e0dbbb2 
jgiannuzzi/mlflow-go#45

Signed-off-by: Software Developer <[email protected]>
@jgiannuzzi jgiannuzzi marked this pull request as draft September 24, 2024 18:32
@jgiannuzzi jgiannuzzi marked this pull request as ready for review October 1, 2024 08:27
dsuhinin
dsuhinin approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@jgiannuzzi jgiannuzzi merged commit 5d387b8 into main Oct 1, 2024
19 checks passed
@jgiannuzzi jgiannuzzi deleted the import branch October 1, 2024 08:41
dsuhinin pushed a commit that referenced this pull request Oct 1, 2024
@jgiannuzzi
Merge pull request #2 from nojaf/debug-thing
c5015fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsuhinin dsuhinin dsuhinin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MLflow-Go Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgiannuzzi @dsuhinin @nojaf