Migrating log-param endpoint. #7
Conversation
Signed-off-by: Software Developer <[email protected]>
yes, Im trying to figure out why this file is not committed. |
Signed-off-by: Software Developer <[email protected]>
Signed-off-by: Software Developer <[email protected]>
Signed-off-by: Software Developer <[email protected]>
Signed-off-by: Software Developer <[email protected]>
| @@ -4,19 +4,26 @@ import "github.com/mlflow/mlflow-go/pkg/protos" | |||
|
|
|||
| type Param struct { | |||
| Key string | |||
| Value string | |||
| Value *string | |||
There was a problem hiding this comment.
MLflow has a special test here to send None so it seems like we can handle it only such way.
| Value string `db:"value" gorm:"column:value;not null"` | ||
| RunID string `db:"run_uuid" gorm:"column:run_uuid;primaryKey"` | ||
| Key string `db:"key" gorm:"column:key;primaryKey"` | ||
| Value sql.NullString `db:"value" gorm:"column:value;not null"` |
There was a problem hiding this comment.
Again, to correctly handle MLFlow None case.
There was a problem hiding this comment.
Should we not discuss this with the mlflow team?
Database schema says it is not null, we even have it in the gorm annotation.
| return contract.NewErrorWith( | ||
| protos.ErrorCode_INTERNAL_ERROR, | ||
| fmt.Sprintf("error creating params in batch for run_uuid %q", runID), | ||
| protos.ErrorCode_BAD_REQUEST, |
There was a problem hiding this comment.
This is the most interesting part. MLFlow test waits for such a status and Im not sure that we can fix it on theirs side or suggest something.
| Value string `db:"value" gorm:"column:value;not null"` | ||
| RunID string `db:"run_uuid" gorm:"column:run_uuid;primaryKey"` | ||
| Key string `db:"key" gorm:"column:key;primaryKey"` | ||
| Value sql.NullString `db:"value" gorm:"column:value;not null"` |
There was a problem hiding this comment.
Should we not discuss this with the mlflow team?
Database schema says it is not null, we even have it in the gorm annotation.
No description provided.