Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate mll-lab/microplate and mll-lab/liquid-handling-robotics #16

Merged
merged 16 commits into from
Apr 24, 2024

Conversation

spawnia
Copy link
Member

@spawnia spawnia commented Apr 23, 2024

No description provided.

composer.json Show resolved Hide resolved
src/Microplate/Enums/FlowDirection.php Outdated Show resolved Hide resolved
@spawnia spawnia requested a review from simbig April 23, 2024 08:11
@spawnia spawnia changed the title Integrate mll-lab/microplate Integrate mll-lab/microplate and mll-lab/liquid-handling-robotics Apr 23, 2024
@spawnia spawnia requested a review from simbig April 23, 2024 16:10
@simbig
Copy link
Contributor

simbig commented Apr 24, 2024

@spawnia One mutation test does seem to be flaky, but I do not understand why....
https://github.com/mll-lab/php-utils/actions/runs/8802746498/job/24159234817?pr=16

@spawnia
Copy link
Member Author

spawnia commented Apr 24, 2024

@spawnia One mutation test does seem to be flaky, but I do not understand why.... https://github.com/mll-lab/php-utils/actions/runs/8802746498/job/24159234817?pr=16

Yeah, that one keeps failing randomly. I don't actually pay attention to mutation testing, perhaps we should just disable it?

@spawnia spawnia merged commit b6b46e4 into master Apr 24, 2024
29 of 30 checks passed
@spawnia spawnia deleted the microplate branch April 24, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants