Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rack to object with positions #29

Merged
merged 25 commits into from
Aug 6, 2024
Merged

Rack to object with positions #29

merged 25 commits into from
Aug 6, 2024

Conversation

simbig
Copy link
Contributor

@simbig simbig commented Aug 5, 2024 •
edited
Loading

  • Added automated tests
  • Documented for all relevant versions
  • Updated the changelog

Changes

  • add specific class for each MLLLabWareRack-type that includes a positions-Collection

Breaking changes

  • delete MLLLabWareRack-class
  • add positionCount-method to Rack-interface
  • delete CustomRack-class
  • limit the usage of BarcodeLocation to ScannedRack-objects

@simbig simbig requested review from spawnia and fischerl August 5, 2024 11:16
spawnia
spawnia reviewed Aug 5, 2024
View reviewed changes
src/Tecan/Rack/InvalidPositionOnRack.php Outdated Show resolved Hide resolved
src/Tecan/Rack/InvalidPositionOnRack.php Outdated Show resolved Hide resolved
src/Tecan/Rack/RackBase.php Outdated Show resolved Hide resolved
src/Tecan/Rack/RackBase.php Outdated Show resolved Hide resolved
src/Tecan/Rack/RackBase.php Outdated Show resolved Hide resolved
src/Tecan/Rack/ScannedRack.php Show resolved Hide resolved
tests/Tecan/Rack/RackTest.php Outdated Show resolved Hide resolved
@spawnia
Copy link
Member

spawnia commented Aug 5, 2024

Labware wie im Titel des Merge Requests oder LabWare?

@simbig simbig changed the title Labware rack to object with positions Rack to object with positions Aug 6, 2024
@simbig
Copy link
Contributor Author

simbig commented Aug 6, 2024

Labware wie im Titel des Merge Requests oder LabWare?

habe die entsprechende Klasse gelöscht. Richtig, wäre Labware (https://www.tecan.com/knowledge-portal/how-to-create-labware-in-storage-carriers-hotels-carousel-stacker-and-tube-runners)

@simbig simbig requested a review from spawnia August 6, 2024 07:57
spawnia
spawnia reviewed Aug 6, 2024
View reviewed changes
src/Tecan/Rack/BaseRack.php Outdated Show resolved Hide resolved
spawnia
spawnia reviewed Aug 6, 2024
View reviewed changes
src/Tecan/Rack/BaseRack.php Outdated Show resolved Hide resolved
@simbig simbig merged commit 3b6a13a into master Aug 6, 2024
33 checks passed
@simbig simbig deleted the labware-rack-to-object-with-positions branch August 6, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spawnia spawnia spawnia approved these changes

@fischerl fischerl Awaiting requested review from fischerl

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simbig @spawnia