Feat/adaptive avg pool #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cxzhang4
commented
Oct 14, 2024
cxzhang4
commented
- Verify the tests are comprehensive enough, in particular the adaptive_avg_output_shape tests that have randomness
…tput shape calculation is causing tests to fail
…ut size as the conv dim. still wrong
…ng in the avg pooling docs
sebffischer
requested changes
Oct 15, 2024
Co-authored-by: Sebastian Fischer <[email protected]>
Co-authored-by: Sebastian Fischer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.