Remove recommendation not to have the AS generated keys #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekr
requested review from
beurdouche and
bifurcation
and removed request for
beurdouche
beurdouche
requested changes
Nov 8, 2023
|
In what use cases does the AS generate the key pairs? |
|
Maybe we could just strengthen the text to say basically: "Some service did this in the past. DON'T DO THIS!!!! (really!)" |
|
See above. |
rohan-wire
approved these changes
Nov 12, 2023
|
I misread Ekr's comment in my first review. We actually all agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the text suggesting that the AS not generate keys. I agree that this is the best practice, but it's just such a standard practice that i think even mentioning the alternative creates confusion.