#252: Discuss Welcome/Commit coupling #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanmahy
reviewed
Jun 7, 2024
draft-ietf-mls-architecture.md
Outdated
Comment on lines
816
to
820
| of the previous group's members). However this operation is not always atomic, | ||
| so it's possible for a member to go offline after committing a ReInit proposal | ||
| but before creating the new group. When this happens, it's necessary for another | ||
| member to continue the reinitialization by creating the new group and sending | ||
| out Welcome messages. |
There was a problem hiding this comment.
Well, it is possible to design a client that does that, but it is also possible to design ones that always do generate the new group atomically. Is there a technical reason to NOT generate the ReInit Commit and create the new group as a single step?
There was a problem hiding this comment.
There's not a technical reason to make it not atomic. Like you say, it's possible, and doing so would avoid this issue. But I don't think it's something worth requiring
rohanmahy
reviewed
Jun 10, 2024
rohanmahy
approved these changes
Jun 10, 2024
Co-authored-by: Rohan Mahy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.